-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Phi] trans logsumexp op #40790
[Phi] trans logsumexp op #40790
Conversation
|
||
#include "paddle/phi/kernels/impl/logsumexp_kernel_impl.h" | ||
|
||
PD_REGISTER_KERNEL( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里缩进好像有点问题
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
@@ -0,0 +1,33 @@ | |||
../ paddle / phi / kernels / impl / |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里也是格式有点问题
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
#include "paddle/phi/kernels/funcs/diagonal.h" | ||
#include "paddle/phi/kernels/funcs/eigen/common.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这两个头文件似乎没有用到
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
#include "paddle/phi/kernels/funcs/diagonal.h" | ||
#include "paddle/phi/kernels/funcs/eigen/common.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
#include "paddle/phi/kernels/funcs/diagonal.h" | ||
#include "paddle/phi/kernels/funcs/eigen/common.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
#include "paddle/phi/kernels/funcs/diagonal.h" | ||
#include "paddle/phi/kernels/funcs/eigen/common.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
#include <type_traits> | ||
#include <vector> | ||
|
||
#include "paddle/fluid/framework/tensor_util.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tensor_util.h似乎没有用到
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
KernelSignature LogsumexpOpArgumentMapping(const ArgumentMappingContext& ctx) { | ||
return KernelSignature( | ||
"logsumexp", {"X"}, {"axis", "keepdim", "reduce_all"}, {"Out"}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个前向的ArgumentMapping感觉可以不写,使用默认的应该也能work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
#include "paddle/phi/kernels/funcs/diagonal.h" | ||
#include "paddle/phi/kernels/funcs/eigen/common.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这俩个头文件应该没用到吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
#include "paddle/phi/kernels/funcs/diagonal.h" | ||
#include "paddle/phi/kernels/funcs/eigen/common.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
#include "paddle/phi/kernels/funcs/diagonal.h" | ||
#include "paddle/phi/kernels/funcs/eigen/common.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
#include "paddle/phi/kernels/funcs/diagonal.h" | ||
#include "paddle/phi/kernels/funcs/eigen/common.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
PR types
New features
PR changes
OPs
Describe
trans logsumexp op