Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[phi] transfer unsqueeze and squeeze to phi #40596

Merged
merged 7 commits into from
Mar 23, 2022
Merged

[phi] transfer unsqueeze and squeeze to phi #40596

merged 7 commits into from
Mar 23, 2022

Conversation

2742195759
Copy link
Contributor

@2742195759 2742195759 commented Mar 15, 2022 •
edited
Loading

PR types

Others

PR changes

Others

Describe

[phi] transfer unsqueeze and squeeze to phi

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

YuanRisheng
YuanRisheng reviewed Mar 16, 2022
View reviewed changes
Copy link
Contributor

@YuanRisheng YuanRisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个benchmark有补充了吗

@2742195759
Copy link
Contributor Author

这个benchmark有补充了吗

benchmark 自带了。 unsqueeze和squeeze都有的

YuanRisheng
YuanRisheng reviewed Mar 16, 2022
View reviewed changes
paddle/phi/infermeta/unary.h Outdated
@@ -34,6 +34,11 @@ class MetaConfig;
//
// The InferMeta Functions in this file are arranged in alphabetic order.

void UnsqueezeInferMeta(const MetaTensor& x,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在这个infermeta有需要按照字典序写的要求，改个位置吧

@2742195759 2742195759 changed the title transfer unsqueeze to phi [phi] transfer unsqueeze to phi Mar 17, 2022
ZzSean
ZzSean approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@ZzSean ZzSean left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for op benchmark

chenwhql
chenwhql approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for PADDLE_ENFORCE

chenwhql
chenwhql reviewed Mar 22, 2022
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两个kernel是不是都是设备无关的实现，按理说应该像reshape一样放到kernels根目录下？

@2742195759
Copy link
Contributor Author

这两个kernel是不是都是设备无关的实现，按理说应该像reshape一样放到kernels根目录下？

好的，下一个PR修改放置位置。

XiaoguangHu01
XiaoguangHu01 approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aurelius84 Aurelius84 merged commit 9121115 into PaddlePaddle:develop Mar 23, 2022
@2742195759 2742195759 changed the title [phi] transfer unsqueeze to phi [phi] transfer unsqueeze and squeeze to phi Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenwhql chenwhql chenwhql approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@ZzSean ZzSean ZzSean approved these changes

@YuanRisheng YuanRisheng YuanRisheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@2742195759 @chenwhql @YuanRisheng @ZzSean @XiaoguangHu01 @Aurelius84