Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[phi] move elementwise_max, elementwise_min, elmentwise_mod into phi #40590

Merged
merged 1 commit into from
Mar 25, 2022
Merged

[phi] move elementwise_max, elementwise_min, elmentwise_mod into phi #40590

merged 1 commit into from
Mar 25, 2022

Conversation

FlyingQianMM
Copy link
Contributor

@FlyingQianMM FlyingQianMM commented Mar 15, 2022 •
edited
Loading

PR types

Function optimization

PR changes

OPs

Describe

[phi] move elementwise_max, elementwise_min, elementwise_mod into phi

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Mar 15, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@FlyingQianMM FlyingQianMM changed the title [phi] move elementwise_max, elementwise_min into phi [phi] move elementwise_max, elementwise_min, elmentwise_mod into phi Mar 21, 2022
zyfncg
zyfncg approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@zyfncg zyfncg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这几个有op-benchmark脚本吗？

@FlyingQianMM
Copy link
Contributor Author

FlyingQianMM commented Mar 24, 2022 •
edited
Loading

这几个有op-benchmark脚本吗？

@zyfncg maximum和minimum的有，但是Modulo没有。这个pr合入后，我再加下op-benchmark的

@FlyingQianMM FlyingQianMM reopened this Mar 24, 2022
XiaoguangHu01
XiaoguangHu01 approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FlyingQianMM FlyingQianMM merged commit cfadf61 into PaddlePaddle:develop Mar 25, 2022
@piDack piDack mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@YuanRisheng YuanRisheng YuanRisheng approved these changes

@MingMingShangTian MingMingShangTian MingMingShangTian approved these changes

@zyfncg zyfncg zyfncg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@FlyingQianMM @CLAassistant @zyfncg @MingMingShangTian @YuanRisheng @XiaoguangHu01