-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Phi] Move grid sample op kernel into phi #40585
[Phi] Move grid sample op kernel into phi #40585
Conversation
Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
const int in_h, | ||
const int in_w, | ||
bool align_corners, | ||
std::string padding_mode, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里用const string&
会不会更高效一些?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯嗯,这里原先代码未做改动,后续完善
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* add grid sample phi kernel * add grid sample phi kernel and remove original kernel * replace mutable_data by alloc
PR types
Function optimization
PR changes
OPs
Describe
[Phi] Move grid sample op kernel into phi