Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Phi] Migrate triangular_solve dependence to phi #40417

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

zhwesky2010
Copy link
Contributor

@zhwesky2010 zhwesky2010 commented Mar 10, 2022

PR types

Function optimization

PR changes

OPs

Describe

lstsq、lu 依赖triangular_solve 的kernel,这个PR将 lstsq、lu 的依赖改成新的 TriangularSolveKernel 形式,同时移除老版本的TriangularSolve的kernel实现。

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 10, 2022

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhwesky2010 zhwesky2010 force-pushed the triangular_solve_phi1 branch from 9d94134 to b99c991 Compare March 10, 2022 10:48
@zhwesky2010 zhwesky2010 force-pushed the triangular_solve_phi1 branch from b99c991 to d6fd478 Compare March 11, 2022 03:53
@zhwesky2010 zhwesky2010 changed the title [Phi]Migrate triangular_solve dependence to phi [Phi] Migrate triangular_solve dependence to phi Mar 11, 2022
@zhwesky2010 zhwesky2010 force-pushed the triangular_solve_phi1 branch from d6fd478 to 285274e Compare March 11, 2022 09:06
@zhwesky2010 zhwesky2010 force-pushed the triangular_solve_phi1 branch from 285274e to 2c8be79 Compare March 14, 2022 03:23
Copy link
Contributor

@MingMingShangTian MingMingShangTian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit 930a513 into PaddlePaddle:develop Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants