[PHI] Move arg min max to PHI. #40222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyfncg
reviewed
Mar 7, 2022
| int64_t axis, | ||
| bool keepdims, | ||
| bool flatten, | ||
| int dtype, |
There was a problem hiding this comment.
可否后续PR优化，有一些直接 dtype 与数字比较的代码。
template <typename DeviceContext, typename T, ArgMinMaxType EnumArgMinMaxValue>
class ArgMinMaxKernel : public framework::OpKernel<T> {
public:
void Compute(const framework::ExecutionContext& ctx) const override {
auto& dtype = ctx.Attr<int>("dtype");
if (dtype < 0) {
framework::VisitDataType(
static_cast<framework::proto::VarType::Type>(
framework::proto::VarType::INT64),
VisitDataArgMinMaxFunctor<DeviceContext, T, EnumArgMinMaxValue>(ctx));
return;
}
framework::VisitDataType(
static_cast<framework::proto::VarType::Type>(dtype),
VisitDataArgMinMaxFunctor<DeviceContext, T, EnumArgMinMaxValue>(ctx));
}
};
paddle/phi/kernels/arg_max_kernel.h
Outdated
| int64_t axis, | ||
| bool keepdims, | ||
| bool flatten, | ||
| int dtype, |
| @@ -0,0 +1,189 @@ | |||
| /* Copyright (c) 2018 PaddlePaddle Authors. All Rights Reserved. | |||
| #include <string> | ||
| #include <typeinfo> | ||
| #include <vector> | ||
| #include "paddle/fluid/operators/transpose_op.h" |
There was a problem hiding this comment.
如果用了transpose_op相关的函数，可以尝试下能否直接使用phi下的transpose kernel
YuanRisheng
reviewed
Mar 7, 2022
YuanRisheng
approved these changes
Mar 9, 2022
zyfncg
approved these changes
Mar 9, 2022
| namespace cub = hipcub; | ||
| #endif | ||
| #include <limits> | ||
| #include "paddle/fluid/framework/data_type.h" |
There was a problem hiding this comment.
paddle/fluid/framework/data_type.h这个fluid下的头文件应该不需要了，在后续PR中移除一下
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
Move arg min max to PHI.