-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Phi] move the graph_send_recv op to the phi #40092
Conversation
✅ This PR's description meets the template requirements! |
Thanks for your contribution! |
}; | ||
|
||
template <typename T, typename IndexT, typename Functor> | ||
void elementwise_inner_operation(const DenseTensor& src, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个函数命名不符合代码规范,驼峰命名
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个函数命名不符合代码规范,驼峰命名
已更改
namespace phi { | ||
|
||
template <typename T, typename IndexT, typename Functor> | ||
void graph_send_recv_cpu_for_loop_grad(const int& input_size, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
已更改
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个op补充了benchmark脚本了吗
#include <algorithm> | ||
#include <vector> | ||
|
||
#include "paddle/fluid/operators/eigen/eigen_function.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个头文件有用到吗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个头文件有用到吗
没有用到,已删除
#include "paddle/phi/kernels/gpu/graph_send_recv_funcs.h" | ||
#include "paddle/phi/kernels/graph_send_recv_kernel.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这两个头文件的顺序可以调下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这两个头文件的顺序可以调下
已调序
op benchmark已增加 |
#include "paddle/phi/kernels/gpu/graph_send_recv_funcs.h" | ||
#include "paddle/phi/kernels/graph_send_recv_grad_kernel.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这两个头文件的顺序后面可以调一下
PR types
Function optimization
PR changes
OPs
Describe
move the graph_send_recv op to the phi