Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【phi】migrate gather_tree,reduce_prod to phi #39844

Merged
merged 4 commits into from
Mar 2, 2022

Conversation

Zjq9409
Copy link
Contributor

@Zjq9409 Zjq9409 commented Feb 23, 2022

PR types

Others

PR changes

Others

Describe

迁移gather_tree、reduce_prod算子

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@Zjq9409 Zjq9409 changed the title Migrate Migrate gather_tree_op to phi Feb 23, 2022
@Zjq9409 Zjq9409 changed the title Migrate gather_tree_op to phi 【phi】migrate gather_tree_op to phi Feb 23, 2022
@Zjq9409 Zjq9409 changed the title 【phi】migrate gather_tree_op to phi 【phi】migrate gather_tree,reduce_prod to phi Feb 28, 2022
Copy link
Contributor

@MingMingShangTian MingMingShangTian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

YuanRisheng
YuanRisheng previously approved these changes Mar 1, 2022
Copy link
Contributor

@YuanRisheng YuanRisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这俩op有添加benchmark的脚本吗,如果没有benchmark脚本还需要加一下

@Zjq9409
Copy link
Contributor Author

Zjq9409 commented Mar 1, 2022

这俩op有添加benchmark的脚本吗,如果没有benchmark脚本还需要加一下

gather_tree 没有竞品实现,reduce_prod已经添加测试脚本

@Zjq9409 Zjq9409 dismissed stale reviews from YuanRisheng and MingMingShangTian via be1ca53 March 1, 2022 09:16
Copy link
Contributor

@MingMingShangTian MingMingShangTian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MingMingShangTian MingMingShangTian merged commit 6af2729 into PaddlePaddle:develop Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants