[phi] migrate where_op into phi #39811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronny1996
changed the title
|
Thanks for your contribution! |
ronny1996
force-pushed
the
phi_where
branch
3 times, most recently
from
912bade to
565cab7
Compare
ronny1996
force-pushed
the
phi_where
branch
2 times, most recently
from
f7676ab to
2f7c1bd
Compare
Xreki
reviewed
Feb 24, 2022
| // auto config = backends::gpu::GetGpuLaunchConfig1D(ctx, numel); | ||
| // WhereCUDAKernel< | ||
| // T><<<config.block_per_grid.x, config.thread_per_block.x, 0, stream>>>( | ||
| // numel, cond_data, x_data, y_data, out_data); |
YuanRisheng
reviewed
Feb 25, 2022
Comment on lines
95
to
102
| // Cond | ||
| template <typename T> | ||
| struct CondFunctor { | ||
| inline HOSTDEVICE T operator()(const bool cond, const T x, const T y) const { | ||
| return cond ? x : y; | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
elementwise_functor是放elementwise相关算子的functor，如果CondFunctor只有where_op的GPU Kernel使用，建议将其和实现放在一起，不用单独拿出来
| #include "paddle/phi/kernels/where_kernel.h" | ||
|
|
||
| #include "paddle/phi/kernels/funcs/elementwise_functor.h" | ||
| #include "paddle/phi/kernels/gpu/elementwise.h" |
There was a problem hiding this comment.
这里可以引用funcs下的broadcast_function.h，直接使用elementwise.h会引入更多多余的代码
paddle/phi/infermeta/multiary.cc
Outdated
| PADDLE_ENFORCE_EQ( | ||
| cond_dims, | ||
| x_dims, | ||
| paddle::platform::errors::InvalidArgument( |
paddle/phi/infermeta/multiary.cc
Outdated
| x_dims)); | ||
| PADDLE_ENFORCE_EQ(x_dims, | ||
| y_dims, | ||
| paddle::platform::errors::InvalidArgument( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
迁移where_op，以及修复PR39806comments