Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Eager Hook] Support ReduceHook in GradNodeAccumulation #39674

Merged
merged 8 commits into from
Feb 19, 2022
Merged

[Eager Hook] Support ReduceHook in GradNodeAccumulation #39674

merged 8 commits into from
Feb 19, 2022

Conversation

veyron95
Copy link
Contributor

@veyron95 veyron95 commented Feb 17, 2022 •
edited
Loading

PR types

New features

PR changes

APIs

Describe

The main changes as below:

  1. Move ReduceHook from GradNodeBase to GradNodeAccumulation.
  2. Delete reduce_hook tests in grad_node_info_test.cc.
  3. Add reduce_hook tests in accumulation_node_test.cc.
  4. Update the logic of RegisterReduceHookForTensor func in hook_utils.cc.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@veyron95 veyron95 changed the title [Eager] Support ReduceHook in accumulation_node [Eager] Support ReduceHook in GradNodeAccumulation Feb 17, 2022
jim19930609
jim19930609 previously approved these changes Feb 18, 2022
View reviewed changes
@veyron95 veyron95 changed the title [Eager] Support ReduceHook in GradNodeAccumulation [Eager Hook] Support ReduceHook in GradNodeAccumulation Feb 18, 2022
@veyron95 veyron95 merged commit 06b177c into PaddlePaddle:develop Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim19930609 jim19930609 jim19930609 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@veyron95 @jim19930609