[pten] trans diagonal kernel into pten #39575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
chenwhql
reviewed
Feb 16, 2022
| @@ -12,262 +12,4 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |||
| See the License for the specific language governing permissions and | |||
| limitations under the License. */ | |||
|
|
|||
| #include "paddle/fluid/framework/op_registry.h" | |||
| #include "paddle/fluid/operators/diagonal_op.h" | |||
paddle/fluid/operators/diagonal_op.h
Outdated
| @@ -16,148 +16,3 @@ | |||
| #include <algorithm> | |||
| #include <vector> | |||
| #include "paddle/fluid/framework/op_registry.h" | |||
paddle/pten/kernels/cpu/diagonal.h
Outdated
| namespace pten { | ||
|
|
||
| template <typename T> | ||
| std::vector<T> ComputeDimStride(const std::vector<T> dim) { |
There was a problem hiding this comment.
kernels/funcs下面已经有一个diagonal.h了，这个函数能否一起整合过去？减少一些重名的头文件
There was a problem hiding this comment.
这个函数本身看起来和diagonal没有关系，个人觉得这是一个shape相关的计算函数，或许直接放到的funcs/common_shape.h更合适
paddle/pten/kernels/gpu/diagonal.h
Outdated
|
|
||
| namespace pten { | ||
| template <typename T, int X_DIM_SIZE, int OUT_DIM_SIZE> | ||
| __global__ void Diagonal(const T* data1, |
| #include "paddle/fluid/framework/tensor_util.h" | ||
| #include "paddle/fluid/platform/device/gpu/gpu_primitives.h" | ||
| #include "paddle/pten/core/kernel_registry.h" | ||
| #include "paddle/pten/kernels/diagonal_grad_kernel.h" |
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| #include "paddle/fluid/framework/tensor_util.h" |
| #include "paddle/fluid/framework/tensor_util.h" | ||
| #include "paddle/fluid/platform/device/gpu/gpu_primitives.h" | ||
| #include "paddle/pten/core/kernel_registry.h" | ||
| #include "paddle/pten/kernels/diagonal_kernel.h" |
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| #include "paddle/fluid/framework/tensor_util.h" |
|
|
||
| namespace pten { | ||
|
|
||
| KernelSignature DiagonalOpArgumentMapping(const ArgumentMappingContext& ctx) { |
There was a problem hiding this comment.
前向的这里不需要写，因为原先的OpMaker就比较规范，会自动正确匹配
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Others