-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PTen]Refactor scale kernel that has selected_rows input #39278
[PTen]Refactor scale kernel that has selected_rows input #39278
Conversation
Thanks for your contribution! |
namespace pten { | ||
|
||
template <typename T, typename Context> | ||
void ScaleSR(const Context& dev_ctx, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个名字需要加Kernel后缀吗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我想了想还是加上吧,顺便把中间层API也加上,下个PR补一下
#include "paddle/pten/backends/gpu/gpu_context.h" | ||
#include "paddle/pten/core/kernel_registry.h" | ||
|
||
// See Note [ Why still include the fluid headers? ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这行注释可以删除了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的,下个PR处理
@@ -0,0 +1,68 @@ | |||
/* Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
下个pr处理
PR types
Others
PR changes
OPs
Describe
将输入为selected_rows的scale_kernel迁移至pten