[PTEN] Move dynload from fluid to pten. #39120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Shixiaowei02
approved these changes
Jan 24, 2022
raindrops2sea
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
dynload组件从fluid中移到pten库中。
注意：dynload依然依赖了glog、gflags。尝试将gflags从dynload中移除，CI上遇到难以计数的单测问题，且框架本身现有的FLAGS过多，去除gflags需花费较多时间梳理工作。
TODO：
1、Pten库最好有自己的flags和log组件，防止和业务使用的gflags、glog出现版本冲突；