Quantize nearest_interp and nearest_interp_v2 #38622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
jakpiase
reviewed
Dec 31, 2021
| std::unordered_set<std::string>( | ||
| {"concat", "conv2d", "depthwise_conv2d", "elementwise_add", "fc", | ||
| "matmul", "nearest_interp", "nearest_interp_v2", "pool2d", | ||
| "prior_box", "reshape2", "transpose2", "fusion_gru", "fusion_lstm", |
There was a problem hiding this comment.
Just for my curiosity, what is prior_box? Do we support that operation?
There was a problem hiding this comment.
I have found it already, I think that it is the only op that doesn't end with "mkldnn_op.cc"
There was a problem hiding this comment.
Yes, you are right, we are using a native version here which supports all data types including int8.
jakpiase
approved these changes
Dec 31, 2021
| std::unordered_set<std::string>( | ||
| {"concat", "conv2d", "depthwise_conv2d", "elementwise_add", "fc", | ||
| "matmul", "nearest_interp", "nearest_interp_v2", "pool2d", | ||
| "prior_box", "reshape2", "transpose2", "fusion_gru", "fusion_lstm", |
There was a problem hiding this comment.
I have found it already, I think that it is the only op that doesn't end with "mkldnn_op.cc"
lidanqing-intel
approved these changes
Jan 4, 2022
|
@baoachun Can I merge this PR? |
wozna
requested review from
lidanqing-intel
and removed request for
Aganlengzi and
sfraczek
|
@Aganlengzi Hi Baoachun approved. Please merge this PR, Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
OPs
Describe
This PR adds:
cpu_quantize_placement_pass.ccadded checking if the list of operators entered by the user contains all the operators supported by quantizationNearest_interp quantization improved the performance by 2% in the "faster_rcnn" model and almost 11% in the "ocr_det" model.