Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Paddle-TRT] Fix dynamic_shape_ernie_test resource life cycle #38374

Conversation

zlsh80826
Copy link
Collaborator

@zlsh80826 zlsh80826 commented Dec 22, 2021

PR types

Others

PR changes

Others

Describe

In the previous PR(#38056), we found the FP32 precision has problem on fp16 tests.
However, the root cause is the emb_layernorm dtor calls terminate(). But the terminate() should be called by TensorRT instead of the plugin. It caused two times cudaFree().

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zlsh80826 zlsh80826 force-pushed the fix_dynamic_shape_ernie_resource branch from a4e55ee to a6c3bf8 Compare December 23, 2021 05:46
shangzhizhou
shangzhizhou previously approved these changes Dec 24, 2021
Copy link
Member

@shangzhizhou shangzhizhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paddle-bot-old
Copy link

Sorry to inform you that a6c3bf8's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Copy link
Member

@shangzhizhou shangzhizhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shangzhizhou shangzhizhou merged commit ba41196 into PaddlePaddle:develop Jan 4, 2022
@zlsh80826 zlsh80826 changed the title fix dynamic_shape_ernie_test resource life cycle [Paddle-TRT] fix dynamic_shape_ernie_test resource life cycle Jan 6, 2022
@zlsh80826 zlsh80826 changed the title [Paddle-TRT] fix dynamic_shape_ernie_test resource life cycle [Paddle-TRT] Fix dynamic_shape_ernie_test resource life cycle Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants