Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for elementwise_add_grad GetExpectedKernelType function #38176

Merged

Conversation

arlesniak
Copy link
Contributor

@arlesniak arlesniak commented Dec 15, 2021

PR types

Bug fixes

PR changes

Others

Describe

Fix for wrong conditions between forward and backward in elementwise_add_grad op

@paddle-bot-old
Copy link

paddle-bot-old bot commented Dec 15, 2021

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@arlesniak arlesniak requested a review from jczaja December 15, 2021 16:31
@arlesniak arlesniak requested a review from jakpiase December 15, 2021 16:32
@jczaja
Copy link
Contributor

jczaja commented Dec 16, 2021

@arlesniak Could you please paste a shape from this op that this change to enable?

Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakpiase jakpiase self-requested a review December 16, 2021 18:10
Copy link
Contributor

@jakpiase jakpiase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arlesniak
Copy link
Contributor Author

@Aganlengzi Could you please review and merge this PR?

Copy link
Contributor

@Aganlengzi Aganlengzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aganlengzi Aganlengzi merged commit d9780a2 into PaddlePaddle:develop Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants