Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache scope and place on CinnLaunchContext and pass them to callback #37983

Merged
merged 4 commits into from
Dec 9, 2021
Merged

cache scope and place on CinnLaunchContext and pass them to callback #37983

merged 4 commits into from
Dec 9, 2021

Conversation

CtfGo
Copy link
Contributor

@CtfGo CtfGo commented Dec 8, 2021 •
edited
Loading

PR types

Function optimization

PR changes

OPs

Describe

cinn_launch_op： cache scope and place on CinnLaunchContext to skip duplicate alloc/free callback construction

cinn_launch_op_test passed:
image

@paddle-bot-old
Copy link

paddle-bot-old bot commented Dec 8, 2021 •
edited
Loading

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Dec 8, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CtfGo CtfGo changed the title cache scope and place on CinnLaunchContext to skip duplicate alloc/free callback construction cache scope and place on CinnLaunchContext and pass them to callback Dec 8, 2021
zhhsplendid
zhhsplendid approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wzzju
wzzju approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@wzzju wzzju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some details can be improved in the next PR.

@zhhsplendid zhhsplendid merged commit 151c5d7 into PaddlePaddle:develop Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzzju wzzju wzzju approved these changes

@zhhsplendid zhhsplendid zhhsplendid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CtfGo @zhhsplendid @wzzju