elementwise_mul refactor #37471
Merged
elementwise_mul refactor #37471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zyfncg
previously approved these changes
Nov 24, 2021
paddle/pten/kernels/cuda/math.cu
Outdated
| // Create the definition of ElementwiseMul | ||
| DEFINE_ELEMENTWISE_OP(Mul) | ||
| // Create the definition of ElementwiseDiv | ||
| DEFINE_ELEMENTWISE_OP(Div) |
There was a problem hiding this comment.
在CPU的math.cc里没定义Div，这里是多写了吗？
There was a problem hiding this comment.
没有多写，CUDA下的div函数删掉了，取而代之用这个div，cpu下的以前的div没删掉，所以没写
chenwhql
reviewed
Nov 24, 2021
| @@ -228,4 +228,29 @@ struct SameDimsElementwiseCompute { | |||
| } | |||
| }; | |||
|
|
|||
| #define DEFINE_ELEMENTWISE_OP(name) \ | |||
There was a problem hiding this comment.
如果一定要用这种形式缩减代码，建议将宏定义放到kernels/cpu/**.h中，functions中的内容定位是由kernel来调用的，反向决定kernel的写法是不合适的
| ASSERT_NEAR(expect_result[0][0], actual_result0, 1e-6f); | ||
| ASSERT_NEAR(expect_result[0][1], actual_result1, 1e-6f); | ||
| ASSERT_NEAR(expect_result[1][0], actual_result2, 1e-6f); | ||
| } |
Zjq9409
pushed a commit
to Zjq9409/Paddle
that referenced
this pull request
Dec 10, 2021
* elementwise_mul refactor * perfect code in test * delete redundant code * fix bugs when run test_multiply * adjust the location of macro * fix bugs when run ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
Refactor elementwise_mul kernel and slim elementwise code.