[bug fix] Fix problem where dp grad merge not compatible with ClipGradientByGlobalNorm function #36334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
FeixLiu
changed the title
FeixLiu
changed the title
| # We need to handle the correct block, otherwise will encounter | ||
| # a 'NotFoundError' during compile time. | ||
| block = default_main_program().current_block() | ||
| block.append_op( |
There was a problem hiding this comment.
可行，但考虑到未来存在更新g.block的可能性，使用current_block是最保险的。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Describe
fix_dp_grad_merge_with_grad_clip_by_global_norm