Make cudnn convolution layer and projection support for dilation #3629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingqing01
reviewed
Aug 23, 2017
paddle/cuda/src/hl_cuda_cudnn.cc
Outdated
| mode, | ||
| data_type)); | ||
| #else | ||
| if (dilation_h > 1 || dilation_w > 1) { | ||
| LOG(FATAL) | ||
| << "Current cudnn version does't support for dilation convolution."; |
There was a problem hiding this comment.
"Current cuDNN version does't support for dilation convolution. The dilation convolution requires cuDNN >= v6.0."
| testProjectionConv(1, true); | ||
| testProjectionConv(3, true); | ||
| /// testProjectionConv(1, true); | ||
| /// testProjectionConv(3, true); |
| @@ -870,12 +871,15 @@ def __init__(self, | |||
| caffe_mode=True, | |||
| filter_size_y=None, | |||
| padding_y=None, | |||
| dilation_y=None, | |||
| stride_y=None): | |||
There was a problem hiding this comment.
It's better to move dilation=None and dilation_y=None to last line.
| dilation_y = dilation | ||
|
|
||
| if dilation > 1 or dilation_y > 1: | ||
| assert layer_type in ["cudnn_conv", "cudnn_convt"] |
There was a problem hiding this comment.
If the layer_type =None, this line will fail.
| @@ -2340,13 +2340,15 @@ def img_conv_layer(input, | |||
| groups=1, | |||
| stride=1, | |||
| padding=0, | |||
| dilation=0, | |||
qingqing01
approved these changes
Aug 24, 2017
heavengate
pushed a commit
to heavengate/Paddle
that referenced
this pull request
Aug 16, 2021
* add flops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3628