-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add shared warpctc lib in whl #3503
Conversation
I just found that:
and
Maybe we can remove it now? And should we add some unit test for loading warpctc just like |
@tensor-tang Discuss with @Xreki , we remain these related codes currently, as we may build libwarpctc.a later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
仔细分析了下,目前
另外,在对 |
这一点,以前实际就是安装到
如果用户在使用c-api的时候,不删除 不管怎么样,安装到哪个目录从我这里是code上都是能实现的,主要是符合paddle的设计需求就行。
另外关于WarpCTC,我觉得是不是可以也给一个 |
你可能误解我的意思了。
用户希望将
关于 |
解释下哈,这里可能是我之前没说清楚,最开始是在安装third party 的 mkldnn的时候是直接安装到
就像你说的,我知道你说的是paddle 的
同时,就像你在#3524 中说的:"Furthermore, I think maybe all the depended third_party libraries should be copied to CMAKE_PREFIX_INSTALL, because they may need to link these libraries when linking c-api library of Paddle. It is another topic."
以上仅仅是一些个人观点和concern哈。 |
Inspired by #3461 , add shared warpctc lib in whl.
pip install *.whl
, we can run warpctc layer exactly.export LD_LIBRARY_PATH=$PADDLE_INSTALL_DIR/Paddle/third_party/install/warpctc/lib:$LD_LIBRARY_PATH
to run warpctc layer.