Using constructor to create an operator. #3444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangkuiyi
approved these changes
Aug 14, 2017
jacquesqiao
reviewed
Aug 14, 2017
paddle/framework/operator.h
Outdated
| const std::string Type() const { return type_; } | ||
| const std::vector<std::string> Inputs() const { return inputs_; } | ||
| const std::vector<std::string> Outputs() const { return outputs_; } | ||
| std::string Type() const { return type_; } |
There was a problem hiding this comment.
这里也应该是
const std::string& Type() const { return type_; }
jacquesqiao
reviewed
Aug 14, 2017
| "Output of FillZerosLikeOp must be set."); | ||
| ctx.Output<framework::Tensor>(0)->Resize( | ||
| ctx.Input<framework::Tensor>(0)->dims()); | ||
| ctx.Output<framework::Tensor>("Dst")->Resize( |
There was a problem hiding this comment.
这里因为Ouput("")里做了check了。
jacquesqiao
reviewed
Aug 14, 2017
paddle/operators/net_op.cc
Outdated
| } | ||
| } | ||
|
|
||
| attrs_["temporary_index"] = tmp_index; | ||
| auto& inputs = inputs_[kAll]; |
jacquesqiao
approved these changes
Aug 14, 2017
dzhwinter
reviewed
Aug 14, 2017
paddle/framework/backward_test.cc
Outdated
| @@ -51,8 +50,8 @@ class MulOpMaker : public OpProtoAndCheckerMaker { | |||
| public: | |||
| MulOpMaker(OpProto *proto, OpAttrChecker *op_checker) | |||
| : OpProtoAndCheckerMaker(proto, op_checker) { | |||
| AddInput("A", "A"); | |||
| AddInput("B", "B"); | |||
| AddInput("X", "A"); | |||
There was a problem hiding this comment.
maybe we need to unify the comment and parameter name? it seems confusing.
paddle/framework/backward.cc
Outdated
| @@ -93,9 +103,11 @@ std::shared_ptr<OperatorBase> BackwardRecursive( | |||
| auto fwd = *it; | |||
| auto bwd = BackwardRecursive(*fwd, no_grad_names, uniq_id); | |||
There was a problem hiding this comment.
uniq_id use type of reference, which violates the rule in
https://google.github.io/styleguide/cppguide.html#Reference_Arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3438. The commit is 11c3560.
This PR is based on wangkuiyi#13. Because in wangkuiyi#13, we changed the private members of OperatorBase. Please review wangkuiyi#13 first.