Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactorize grad op builder.cc #3433

Merged
merged 5 commits into from
Aug 11, 2017
Merged

Refactorize grad op builder.cc #3433

merged 5 commits into from
Aug 11, 2017

Conversation

wangkuiyi
Copy link
Collaborator

@wangkuiyi wangkuiyi commented Aug 11, 2017 •
edited
Loading

Fixes #3427

@wangkuiyi wangkuiyi requested a review from JiayiFeng August 11, 2017 22:09
JiayiFeng
JiayiFeng reviewed Aug 11, 2017
View reviewed changes
paddle/framework/grad_op_builder.cc
class OpRegistry;

using VarIndexMap = std::unordered_map<std::string, int>;
typedef std::vector<int> Ints;

enum class OpArgType { IN, OUT };
Copy link
Collaborator

@JiayiFeng JiayiFeng Aug 11, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that we don't need OpArgType anymore. Remove it?

JiayiFeng
JiayiFeng approved these changes Aug 11, 2017
View reviewed changes
Copy link
Collaborator

@JiayiFeng JiayiFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JiayiFeng JiayiFeng merged commit e6fca65 into PaddlePaddle:develop Aug 11, 2017
@wangkuiyi wangkuiyi deleted the refactorize_grad_op_builder.cc branch August 11, 2017 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiayiFeng JiayiFeng JiayiFeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangkuiyi @JiayiFeng