Add OperatorBase accessors #3428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangkuiyi
requested review from
Superjomn,
reyoung,
jacquesqiao and
qingqing01
JiayiFeng
reviewed
Aug 11, 2017
| const std::string Type() const { return type_; } | ||
| const std::vector<std::string> Inputs() const { return inputs_; } | ||
| const std::vector<std::string> Outputs() const { return outputs_; } | ||
| const AttributeMap& Attrs() const { return attrs_; } |
There was a problem hiding this comment.
Sometimes we do need to change data members, e.g. in the grad_op_builder. Mutable accessors are also required.
There was a problem hiding this comment.
No. I noticed that in grad_op_builder, we can constructor everything before calling the constructor.
There was a problem hiding this comment.
And the name Input is same with the function at line 100. It's a little confusing and maybe we shall rename the function at line 100.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3426