Add master server unit test #3086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helinwang
approved these changes
Jul 27, 2017
There was a problem hiding this comment.
LGTM++!
Some minor comments.
Btw, CI reports:
[03:54:01] make[3]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule.
[03:54:01] make[3]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule.
[03:54:04] [ERROR] [mFailed to install: Unable to get repository
[03:54:04] Unable to get repository
[03:54:04] Unable to get repository
[03:54:04] CMakeFiles/go_vendor.dir/build.make:60: recipe for target 'glide' failed
[03:54:04] CMakeFiles/Makefile2:432: recipe for target 'CMakeFiles/go_vendor.dir/all' failed
[03:54:04] make[2]: *** [glide] Error 1
[03:54:04] make[1]: *** [CMakeFiles/go_vendor.dir/all] Error 2
[03:54:04] make[1]: *** Waiting for unfinished jobs....
[03:54:07] Note: checking out '9f75c5aa851cd877fb0d93ccc31b8567a6706546'.
go/master/service_test.go
Outdated
| log.Fatal(err) | ||
| } | ||
| defer func() { | ||
| e.Close() |
There was a problem hiding this comment.
Need to handle error, otherwise gometalinter check would not pass.
There was a problem hiding this comment.
It seems that Close() function return nothing.
go/master/service_test.go
Outdated
| defer func() { | ||
| e.Close() | ||
| if err := os.RemoveAll(etcdDir); err != nil { | ||
| log.Fatal(err) |
There was a problem hiding this comment.
Could use t.Fatal(err) here.
go/master/service_test.go
Outdated
| }() | ||
| select { | ||
| case <-e.Server.ReadyNotify(): | ||
| log.Printf("Server is ready!") |
There was a problem hiding this comment.
Maybe t.Log would be better (prints only when test failed or -v is specified). Same for other places.
|
CI failed because the develop branch is not building. Please rebase / pull new develop, it contains the fix. |
|
Thanks @helinwang , fixed the CI failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #3079