fix shape check many by hongyu #16840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingqing01
reviewed
Apr 15, 2019
| PADDLE_ENFORCE_EQ(x_dims[1], y_dims[1], | ||
| "The dim 1 of X and Y must be the same."); | ||
| } | ||
| } |
There was a problem hiding this comment.
For more simply:
if (ctx->IsRuntime() || (framework::product(x_dims) > 0 && framework::product(y_dims))) {
PADDLE_ENFORCE_EQ(x_dims, y_dims, ...)
}但这个check没有当前的code严格
| x_dims, y_dims, | ||
| "Minus operator must take two tensor with same num of elements"); | ||
| } | ||
| } |
There was a problem hiding this comment.
For short lines:
if ( ctx->IsRuntime() || (framework::product(x_dims) > 0 && framework::product(y_dims) > 0) ) {
}| PADDLE_ENFORCE_EQ(x_dims[1], y_dims[1], | ||
| "The dim 1 of X and Y must be the same."); | ||
| } | ||
| } |
… fix_shape_check_many
qingqing01
approved these changes
Apr 16, 2019
phlrain
added a commit
to phlrain/Paddle
that referenced
this pull request
Apr 17, 2019
fix shape check many by hongyu
phlrain
added a commit
that referenced
this pull request
Apr 17, 2019
Merge pull request #16840 from phlrain/fix_shape_check_many
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tensor_array_read_write_op.cc
data_norm_op.cc
huber_loss_op.cc
layer_norm_op.cc
precision_recall_op.cc
minus_op.cc
modified_huber_loss_op.cc
space_to_depth_op.cc
tree_conv_op.cc