[PASS][HuaweiAscendNPU] Fix constant fold pass and solve the precision of ascend meshgrid op #9940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shentanyue
requested review from
mjp9527,
zhupengyang and
hong19860320
as code owners
|
Thanks for your contribution! |
…addlePaddle/Paddle-Lite into fix_constant_fold_pass_and_meshgrid
shentanyue
force-pushed
the
fix_constant_fold_pass_and_meshgrid
branch
from
f4cd74c to
39a103a
Compare
shentanyue
commented
Jan 18, 2023
| @@ -188,7 +188,6 @@ std::unique_ptr<RuntimeProgram> RunDefaultOptimizer( | |||
| "lite_conv_scale_fuse_pass", | |||
| "lite_conv_elementwise_tree_fuse_pass", | |||
| "lite_greater_than_cast_fuse_pass", | |||
| "fill_range_fuse_pass", | |||
There was a problem hiding this comment.
已经有fill_constant和range的常量折叠pass了，这个pass不再需要
| @@ -72,28 +92,26 @@ void RangeCalcOfflinePass::RemoveRangePattern( | |||
| auto step_t = step_var->GetMutable<lite::Tensor>(); | |||
| if (!start_t->persistable() || !end_t->persistable() || | |||
| !step_t->persistable()) { | |||
| LOG(WARNING) << "RangeCalcOfflinePass does not support input that is not " | |||
| "persistable"; | |||
| VLOG(5) | |||
There was a problem hiding this comment.
应该是不希望每次执行都打印太多log吧
There was a problem hiding this comment.
是的，LOG(WARNING)会不受限制的进行打印，有时会输出大量log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR devices
Framework and NNadapter
PR types
Bug fixes
PR changes
PASS and OP
Description
修复常量折叠 Pass 和解决 Ascend meshgrid op 精度问题。