Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yingsheng bd/remove enable int8 in opbridge #5591

Merged
merged 2 commits into from
Mar 5, 2021
Merged

Yingsheng bd/remove enable int8 in opbridge #5591

merged 2 commits into from
Mar 5, 2021

Conversation

yingshengBD
Copy link
Collaborator

remove the attr:enable_int8 in mtkAPU,NNA,rkNPU
test=develop

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 2, 2021

Thanks for your contribution!

@@ -57,7 +57,11 @@ int ConvConverter(void* ctx, OpLite* op, KernelBase* kernel) {
std::vector<int> paddings = op_info->GetAttr<std::vector<int>>("paddings");
auto groups = op_info->GetAttr<int>("groups");
std::vector<int> dilations = op_info->GetAttr<std::vector<int>>("dilations");
auto fuse_relu = op_info->GetAttr<bool>("fuse_relu");
bool fuse_relu = false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个改动的目的是啥?

bool fuse_relu = false;
fuse_relu = op_info->GetAttr<bool>("fuse_relu");
if (fuse_relu) {
VLOG(3) << "!!!the op has RELU ";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log不要写的太随意

Copy link
Collaborator

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hong19860320 hong19860320 merged commit e3fee29 into PaddlePaddle:develop Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants