add 0d autoscan for X86, Metal, OpenCL #10275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lishicheng1996
requested review from
mjp9527,
zhupengyang and
hong19860320
as code owners
|
Thanks for your contribution! |
lishicheng1996
force-pushed
the
x86_metal_opencl_autoscan
branch
from
8c29d07 to
4005198
Compare
lishicheng1996
force-pushed
the
x86_metal_opencl_autoscan
branch
from
59127c8 to
75f38e4
Compare
mjp9527
reviewed
May 17, 2023
| @@ -256,22 +256,6 @@ class ActivationComputeImageDefault | |||
| CL_CHECK_FATAL(status); | |||
| } | |||
|
|
|||
| #ifdef LITE_WITH_LOG | |||
There was a problem hiding this comment.
这个Log信息为啥要删除呀，是因为 x_dims[1] << " " << x_dims[2] << " " << x_dims[3] 这种会访存越界吗
There was a problem hiding this comment.
是的，x_dims的size可能为0, 引发错误。这个pr还没有完全ok，metal elementwise op暂时屏蔽掉了，我还在看。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add 0d autoscan for X86, Metal, OpenCL