Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HuaweiAscendNPU] Add fill_zeros_like and rsqrt op #10138

Merged

Conversation

shentanyue
Copy link
Collaborator

PR devices

NNadapter

PR types

New features

PR changes

OP

Description

RT

@paddle-bot
Copy link

paddle-bot bot commented Mar 27, 2023

Thanks for your contribution!

place = TARGET(kNNAdapter);
#if defined(NNADAPTER_WITH_HUAWEI_ASCEND_NPU)
abs_error = 1e-3;
TestFillZerosLikeNNAdapter(place, abs_error);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么需要加上硬件后缀?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原有的单测用了alias,NNAdapter相关硬件用不了,为了不影响其他单测,所以就新增了个alias="def"的函数,给NNAdapter相关硬件用。

Copy link
Collaborator

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shentanyue shentanyue merged commit 571f418 into PaddlePaddle:develop Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants