[Framework] Update set_model_from_buffer api #10026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shentanyue
requested review from
mjp9527,
zhupengyang and
hong19860320
as code owners
|
Thanks for your contribution! |
shentanyue
force-pushed
the
update_set_model_from_buffer_api_develop
branch
from
f16f4ee to
14ee890
Compare
shentanyue
added a commit
to shentanyue/Paddle-Lite
that referenced
this pull request
Feb 28, 2023
shentanyue
added a commit
that referenced
this pull request
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR devices
Framework
PR types
Others
PR changes
API
Description
之前的 set_model_from_buffer 内部存储会使用 std::string 数据结构，会将传入的 buffer 再拷贝构造一份，造成内存上的重复消耗。
目前改为 const char* 进行数据传递，buffer 的内存释放由用户侧管理。
TODO: 清理LightPredictor读取pdmodel/pdiparams相关API和底层实现。