转换规则 No.48 RNNBase #134
Merged
转换规则 No.48 RNNBase #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
RedContritio
force-pushed
the
RNNBase
branch
2 times, most recently
from
74c3298 to
d50ea32
Compare
ROckDog22
reviewed
Jun 28, 2023
|
请解决下冲突 |
zhwesky2010
reviewed
Jul 11, 2023
zhwesky2010
reviewed
Jul 13, 2023
| if "nonlinearity" in kwargs: | ||
| kwargs["activation"] = kwargs.pop("nonlinearity") | ||
|
|
||
| if "mode" in kwargs: |
There was a problem hiding this comment.
除了这两个判断：
1.判断mode是否为LSTM、GRU
2.判断bidirectional=True
其他地方我觉得都可以用GenericMatcher来实现，分别通过unsupport_args、kwargs_change的json配置就可以，包括bias
There was a problem hiding this comment.
处理了 batch_first，mode 和 bidirectional 三个参数。有个尚存的问题就是，如果 mode 指定为变量，如
import torch
import torch.nn as nn
mode = "LSTM"
model = torch.nn.RNNBase(mode, 16, 32, bidirectional=False)就会无法识别，只能处理常量。其他两个量是 boolean 所以可能影响不大，但是这个是字符串，因此可能会有更大的出错可能性。
There was a problem hiding this comment.
嗯先这么写吧，后面我们会针对这个API支持其他两种常量 'RNN_TANH', 'RNN_RELU
zhwesky2010
approved these changes
Aug 3, 2023
| if "nonlinearity" in kwargs: | ||
| kwargs["activation"] = kwargs.pop("nonlinearity") | ||
|
|
||
| if "mode" in kwargs: |
There was a problem hiding this comment.
嗯先这么写吧，后面我们会针对这个API支持其他两种常量 'RNN_TANH', 'RNN_RELU
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Docs
PR APIs