Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Refine models directory #55

Merged
merged 3 commits into from
Dec 13, 2017
Merged

Refine models directory #55

merged 3 commits into from
Dec 13, 2017

Conversation

hedaoyuan
Copy link
Collaborator

Fix #54

@hedaoyuan hedaoyuan changed the title Refine Refine models directory Dec 12, 2017
@hedaoyuan hedaoyuan requested a review from NHZlX December 12, 2017 07:33
@Xreki
Copy link
Collaborator

Xreki commented Dec 12, 2017

I agree to reorganize the directory, but I am not sure about the sub-directories' name.

@Xreki
Copy link
Collaborator

Xreki commented Dec 12, 2017

In fact, I think the sub-directories' name under deployment is not intuitive. Since #54 is merged, we may keep it and change it in next PR.

About the sub-directory under models, how about change configuration to standard_network_configs?

@hedaoyuan
Copy link
Collaborator Author

About the sub-directory under models, how about change configuration to standard_network_configs?

OK. I will change the directory name to standard_network, and also we can add a README.md to explain the configuration is follow which article.

@Xreki
Copy link
Collaborator

Xreki commented Dec 12, 2017 •
edited
Loading

we can add a README.md to explain the configuration is follow which article.

Yes, indeed we need to add this. Maybe @NHZlX add this in next PR?

@NHZlX NHZlX requested a review from Xreki December 12, 2017 13:10
@hedaoyuan hedaoyuan merged commit 9e2c573 into PaddlePaddle:develop Dec 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Xreki Xreki Xreki approved these changes

@NHZlX NHZlX Awaiting requested review from NHZlX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hedaoyuan @Xreki