Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Add cbrt op #1073

Merged
merged 10 commits into from
Nov 29, 2022
Merged

Add cbrt op #1073

merged 10 commits into from
Nov 29, 2022

Conversation

huangjiyi
Copy link
Member

@huangjiyi huangjiyi marked this pull request as draft November 25, 2022 13:10
Asthestarsfalll
Asthestarsfalll reviewed Nov 25, 2022
View reviewed changes
cinn/runtime/cpu/host_intrinsics.cc Outdated Show resolved Hide resolved
cinn/runtime/cpu/host_intrinsics.h Outdated Show resolved Hide resolved
cinn/hlir/op/contrib/cbrt.cc Show resolved Hide resolved
cinn/hlir/op/contrib/cbrt.cc Show resolved Hide resolved
@huangjiyi huangjiyi marked this pull request as ready for review November 25, 2022 16:39
@huangjiyi
Copy link
Member Author

@thisjiang ，帮忙 review 一下。

@qlogcn qlogcn mentioned this pull request Dec 13, 2022
Closed
thisjiang
thisjiang reviewed Nov 28, 2022
View reviewed changes
cinn/hlir/op/contrib/cbrt.cc Outdated Show resolved Hide resolved
cinn/hlir/op/contrib/cbrt_test.cc Outdated Show resolved Hide resolved
cinn/hlir/op/contrib/cbrt_test.cc Show resolved Hide resolved
python/tests/ops/test_cbrt_op.py Show resolved Hide resolved
@huangjiyi
Copy link
Member Author

@thisjiang ，帮忙再 review 一下

@huangjiyi huangjiyi requested a review from thisjiang November 28, 2022 11:43
thisjiang
thisjiang approved these changes Nov 29, 2022
View reviewed changes
Copy link
Collaborator

@thisjiang thisjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thisjiang thisjiang merged commit ae6a7d2 into PaddlePaddle:develop Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Asthestarsfalll Asthestarsfalll Asthestarsfalll left review comments

@thisjiang thisjiang thisjiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huangjiyi @thisjiang @Asthestarsfalll