Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve clang detection based on #48 for tests #51

Merged
merged 1 commit into from
Jan 7, 2023

Conversation

daniel-j
Copy link
Contributor

@daniel-j daniel-j commented Jan 7, 2023

Should add this proc to the module so that futhark can use it too, as described in #48

@PMunch
Copy link
Owner

PMunch commented Jan 7, 2023

Well with the ability to pass sysPaths as a define I don't think it's necessary to add it to Futhark. Libraries using Futhark should simply add this to their config.nims file. I guess we could have a futhark.nims file that can be imported into config.nims so that getClangIncludePath could be used without having to define it every time though.

@PMunch PMunch merged commit a73fdfc into PMunch:master Jan 7, 2023
@daniel-j
Copy link
Contributor Author

daniel-j commented Jan 7, 2023

Readme should be updated to mention it in that case. I was thinking something along this (although my futhark dot here is not needed, the proc would just be exported and usable):

import futhark
importc:
  sysPath futhark.getClangIncludePath()
  ...

@PMunch
Copy link
Owner

PMunch commented Jan 7, 2023

Hmm, that's fair. Should work just as well. Maybe it should even default to that if no sysPath was defined..

@daniel-j daniel-j deleted the feature-tests-clang-detection branch January 10, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants