This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
generated from googlefonts/googlefonts-project-template
-
Notifications
You must be signed in to change notification settings - Fork 15
Add additional diacritics – aligning to GF Latin Core #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: this upgrades the glyphs file format from v2 to v3
thin and medium align with dieresiscomb ; black unchanged
decompose macron and custom width for thin and medium
note, thin now slightly wider than indended
removing breaking change introduced in a571e6e
hey @Andyfitz keen for a review or if you'd be able to nominate someone from your end. ta ✌️ |
@wayne-shih Thank you so much and my apologies for missing this . I'll review your changes and get back with any feedback at once! |
@wayne-shih I've merged the commit. Thank you! The ™ and ℠ symbols for the heaviest weight might be the only thing there's mixed debate about. For now, existing is better than not existing :) I'll now (finally) roll up a release and get this moving for you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of changes here...!
I started with just wanting to add macrons and arrows, but ended up filling a bunch of missing diacritics -- fully aligning to the GF Latin Core standard. This PR thus... resolves #8, resolves #16, resolves #18
I've also cut a v1.100 release as part of this change @ af02a4d
Approach
I've aligned it to the look and feel of outfit as close as intended, happy to discuss any glyph drawings further.
Preview
Thin
Medium
Black
Builds (ttf / otf / vf / woff2):
/~https://github.com/wayne-shih/Outfit-Fonts/tree/master/fonts
Links
https://wayne-shih.github.io/Outfit-Fonts/fontbakery-report.html
https://wayne-shih.github.io/Outfit-Fonts/glyphs.html
https://wayne-shih.github.io/Outfit-Fonts/text.html
https://wayne-shih.github.io/Outfit-Fonts/waterfall.html