Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: add type support for exported connect #41

Merged
merged 4 commits into from
Nov 19, 2021

Conversation

DeVoresyah
Copy link
Member

connect({}) type support

Add type support for connect({}). It will show suggestion when called inside component / screen

@DeVoresyah DeVoresyah added enhancement New feature or request core All about core and main algorithm labels Nov 18, 2021
@DeVoresyah DeVoresyah changed the base branch from master to development November 18, 2021 05:42
@rizbud
Copy link

rizbud commented Nov 18, 2021

LGTM!

Copy link
Contributor

@ambrizals ambrizals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For suggestion maybe avoid using function to create a new object of class, maybe should be use static method.

@DeVoresyah
Copy link
Member Author

For suggestion maybe avoid using function to create a new object of class, maybe should be use static method.

any example ?

@DeVoresyah
Copy link
Member Author

For suggestion maybe avoid using function to create a new object of class, maybe should be use static method.

I will merge this PR first, later on we can enhance on that

@DeVoresyah DeVoresyah merged commit 125db91 into development Nov 19, 2021
@DeVoresyah DeVoresyah deleted the feature/connect_type branch November 19, 2021 07:47
@DeVoresyah DeVoresyah mentioned this pull request Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core All about core and main algorithm enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants