Add optional replacement to ForbiddenDirectives
#1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
changed the title
ForbiddenDirectives
|
After this PR is merged, I would release a new version, then we need to wait ~10 minutes and then a PR against |
OskarStark
reviewed
Dec 7, 2024
|
Updated the code so it takes an array of replacements. Refactored the tests a bit because there are a lot more variations now. Also added tests for configuration failures. |
OskarStark
added a commit
that referenced
this pull request
Dec 7, 2024
* develop: Add optional replacement to `ForbiddenDirectives` (#1901) Add `make docs` (#1902) composer(deps-dev): bump ergebnis/composer-normalize from 2.44.0 to 2.45.0 (#1899) composer(deps): bump symfony/dependency-injection from 7.1.9 to 7.2.0 (#1898) composer(deps): bump symfony/yaml from 7.1.6 to 7.2.0 (#1897) composer(deps-dev): bump symfony/var-dumper from 7.1.8 to 7.2.0 (#1894) composer(deps): bump symfony/config from 7.1.7 to 7.2.0 (#1896) composer(deps): bump symfony/options-resolver from 7.1.9 to 7.2.0 (#1895) composer(deps): bump symfony/finder from 7.1.6 to 7.2.0 (#1893) composer(deps): bump symfony/console from 7.1.8 to 7.2.0 (#1892) composer(deps): bump symfony/dependency-injection from 7.1.8 to 7.1.9 (#1889) composer(deps): bump symfony/service-contracts from 3.5.0 to 3.5.1 (#1890) composer(deps): bump symfony/options-resolver from 7.1.6 to 7.1.9
|
Thanks @TimoBakx You may want to send a PR to |
|
Yes, I will do that. |
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Dec 7, 2024
…TimoBakx) This PR was merged into the 6.4 branch. Discussion ---------- Added replacement suggestions for forbidden directives Also bumped DOCtor RST workflow to 1.64.0 to allow this (see OskarStark/doctor-rst#1901). Commits ------- 35a3db1 Added replacement suggestions for forbidden directives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1900