Docs: isolate charts in <iframe>s
#173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ods-charts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
julien-deramond
changed the title
<iframe>s
louismaximepiton
force-pushed
the
main-lmp-boosted-4-fix
branch
from
7eebf9c to
5f36a12
Compare
louismaximepiton
force-pushed
the
main-lmp-boosted-4-fix
branch
from
0cd49e5 to
d82cba0
Compare
julien-deramond
approved these changes
Apr 24, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please transform
- [ ]into- (NA)in the description when things are not applicableRelated issues
Closes #169
Description
Set up examples inside iframes to isolate them from the main page CSS and JS.
Simplify a bit the index.js.
Changing the library (could be done separately) to handle larger markups.
Tried my best using webComponents to encapsulate graphs but the JS leaks outside the webcomponent and leads to issues with the js parts, that are called the number of webcomponent inside a page -> Leads to breaking accordions/tooltips, ...
Turning to iframes that encapsulate JS as well but there are some side effects with echarts and our lib right now. The remaining issue can be seen from the 2 last commits of the branch.
Should we have NONE as an option for the theme ?
Motivation & Context
#169.
Avoid changing the CSS from the whole site to see the rendering with Boosted v4. Simplify the html and js from the doc.
Types of change
Test checklist
Please check that the following tests projects are still working:
docs/examplestest/angular-ngx-echartstest/angular-echartstest/htmltest/reacttest/vuetest/examples/bar-line-charttest/examples/single-line-charttest/examples/timeseries-chart