Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

Fix readiness & liveness probe configuration detection #206

Merged

Conversation

erdrix
Copy link
Contributor

@erdrix erdrix commented Mar 18, 2020

Reworks statefulset's changes detection by the operator, to work with live & ready probe configurations.

@erdrix erdrix requested a review from cscetbon March 18, 2020 13:01
@erdrix erdrix added the bug Something isn't working label Mar 18, 2020
@cscetbon
Copy link
Contributor

cscetbon commented Mar 19, 2020

@erdrix I think it's missing a unit test. See

func TestUpdateStatusIfconfigMapHasChangedWithNoConfigMap(t *testing.T) {
on how to use reconcile if you want to test the update of the new parameters. I let you figure out what is the easiest, unit test or e2e

@erdrix
Copy link
Contributor Author

erdrix commented Mar 19, 2020

I'm ok with you about unit test, I added some test but not using the reconcile, the bug was about the StatefulSetsAreEqual function which didn't detecting update, so I added some unit-tests for this function :)
Tell me if its seems enough for you.

Copy link
Contributor

@cscetbon cscetbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erdrix Just the minor change I talked about to remove the unneeded declaration and we're good.

Good job 👏

@erdrix erdrix merged commit 2944ff3 into Orange-OpenSource:master Mar 24, 2020
cscetbon pushed a commit that referenced this pull request Aug 13, 2020
Fix readiness & liveness probe configuration detection
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants