This repository has been archived by the owner on Oct 20, 2022. It is now read-only.
Get only first cluster for watch CRD MultiCassKop #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdrix
commented
Dec 17, 2019
multi-casskop/pkg/controller/multi-casskop/multi-casskop_controller.go
Outdated
Show resolved
Hide resolved
added 7 commits
December 18, 2019 09:11
Watch crd improved
erdrix
added
enhancement
added 10 commits
December 20, 2019 11:14
added 2 commits
December 20, 2019 18:55
…ralty controller, else he can't check resource state.
|
I fixed the bug with remotes watch, into the commit : ebfbbbe, feature is ready to be reviewed. |
cscetbon
reviewed
Jan 5, 2020
cscetbon
reviewed
Jan 5, 2020
|
@erdrix a few minor comments and it's all good |
allamand
previously approved these changes
Jan 5, 2020
added 2 commits
January 6, 2020 08:56
cscetbon
approved these changes
Jan 7, 2020
Orange-cscetbon
approved these changes
Jan 8, 2020
cscetbon
pushed a commit
that referenced
this pull request
Aug 13, 2020
Get only first cluster for watch CRD MultiCassKop & refactor local and remotes declaration
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fast fix, operator stop to watch remote CRD MultiCasskop.
I try to find a more explicit declaration of masters and remotes, using struct or something else.