Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add osi_trafficcommandupdate.proto to CMakeLists #744

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Add osi_trafficcommandupdate.proto to CMakeLists #744

merged 1 commit into from
Dec 4, 2023

Conversation

ClemensLinnhoff
Copy link
Contributor

@ClemensLinnhoff ClemensLinnhoff commented Nov 22, 2023 •
edited
Loading

Reference to a related issue in the repository

#743

Add a description

Add osi_trafficcommandupdate.proto to CMakeLists. Fixing the bug, that no header for osi_trafficcommandupdate is built.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

@ClemensLinnhoff
Add osi_trafficcommandupdate.proto to CMakeLists
2ed930e 
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>
@ClemensLinnhoff ClemensLinnhoff linked an issue Nov 22, 2023 that may be closed by this pull request
TrafficCommandUpdate missing from CMakeLists #743
Closed
@ClemensLinnhoff ClemensLinnhoff requested a review from pmai November 22, 2023 08:46
@jdsika jdsika added the Bug Problems in the build system, build scripts, etc or faults in the interface. label Nov 22, 2023
@jdsika jdsika added this to the V3.7.0 milestone Nov 22, 2023
@pmai pmai added ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. and removed ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels Dec 4, 2023
@pmai
Copy link
Contributor

pmai commented Dec 4, 2023

CCB 2023-12-04: Merge as-is.

@pmai pmai merged commit b1b9c72 into master Dec 4, 2023
@pmai pmai deleted the 743-trafficcommandupdate-missing-from-cmakelists branch December 4, 2023 10:04
@pmai pmai mentioned this pull request Dec 4, 2023
Merged
@jdsika
Copy link
Contributor

jdsika commented Apr 23, 2024

Reviewed for v3.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdsika jdsika jdsika approved these changes

@pmai pmai Awaiting requested review from pmai

Assignees
No one assigned
Labels
Bug Problems in the build system, build scripts, etc or faults in the interface. ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB.
Projects
None yet
Milestone
V3.7.0
Development

Successfully merging this pull request may close these issues.

TrafficCommandUpdate missing from CMakeLists
3 participants
@ClemensLinnhoff @pmai @jdsika