Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new traffic sign variability types #683

Conversation

thomassedlmayer
Copy link
Contributor

@thomassedlmayer thomassedlmayer commented Nov 4, 2022

Description

  • Clarify definition of VARIABILITY_FIXED and VARIABILITY_VARIABLE to differentiate from new types
  • Add new types VARIABILITY_VARIABLE_MOVABLE and VARIABILITY_VARIABLE_MUTABLE

As already mentioned by @jdsika in #623, the differentiation between mutable content (e.g. traffic sign type) and changes in position of traffic signs is not given yet.
To maintain backwards compatibility the existing type VARIABILITY_VARIABLE is essentially kept as it is. It still describes traffic signs that CAN BE semantically and positionally variable. This means that it has to be expected that the traffic sign's type and position could change over time (exactly as it is with the current OSI version). If further differentiation in terms of semantics and position is desired, the new types VARIABILITY_VARIABLE_MOVABLE and VARIABILITY_VARIABLE_MUTABLE can be used.

Examples

VARIABILITY_VARIABLE:

Pickup truck at the Autobahn carries a semantically mutable (e.g. digital) sign for a construction site which moves on the car.

VARIABILITY_VARIABLE_MUTABLE:

Digital or analog mutable traffic signs like signs on a traffic sign gantry.

VARIABILITY_VARIABLE_MOVABLE:

Temporary (but semantically immutable) signs at construction sites.

Checklist

#### References
resolves #623
#671

@thomassedlmayer thomassedlmayer added the Harmonisation The Group in the ASAM development project working on harmonisation with other standards. label Nov 4, 2022
@thomassedlmayer thomassedlmayer added this to the V3.6.0 milestone Nov 4, 2022
@jdsika jdsika added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Nov 4, 2022
@pmai pmai removed the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Nov 7, 2022
@pmai
Copy link
Contributor

pmai commented Nov 7, 2022

CCB 2022-11-07: First to be further discussed in Harmonisation group, and possibly await results from dynamic signs harmonization effort.

@thempen
Copy link
Contributor

thempen commented Nov 9, 2022

The enum VARIABILITY_VARIABLE is not clearly defined, if it is movable and mutable, it can be, or can't. An additional field "VARIABILITY_MOVABLE_AND_MUTABLE" will be more specific.

Movable assumes, you can have a temporary sign e.g., for road works, but also traffic signs on vehicles. @SensorWG: Do we need to distinguish between these tempory signs or signs on vehicles?

@thempen thempen added the SensorModeling The Group in the ASAM development project working on sensor modeling topics. label Nov 9, 2022
Copy link
Contributor

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed changes as per harmonization discussion.

@thempen thempen added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Nov 23, 2022
@pmai pmai added ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. and removed ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels Dec 12, 2022
- Clarify definition of old types to differentiate from new types
- Add new types VARIABLE_MOVABLE and VARIABLE_MUTABLE

Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
@pmai pmai force-pushed the feature/ha/traffic-sign-variability-extension branch from 4a93dce to 4e66c0e Compare December 12, 2022 12:30
@pmai
Copy link
Contributor

pmai commented Dec 12, 2022

CCB 2022-12-12: Merge as-is.

@pmai pmai merged commit 3fac91f into OpenSimulationInterface:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Harmonisation The Group in the ASAM development project working on harmonisation with other standards. ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. SensorModeling The Group in the ASAM development project working on sensor modeling topics.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear meaning of traffic sign - variability
4 participants