Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: lmr: reduce grid margins from 35s to 15s #9984

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

SarahBellaha
Copy link
Contributor

Closes #9946

@SarahBellaha SarahBellaha requested a review from a team as a code owner December 9, 2024 07:13
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.10%. Comparing base (d1826c4) to head (cf356fa).
Report is 20 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9984      +/-   ##
==========================================
- Coverage   80.12%   80.10%   -0.02%     
==========================================
  Files        1048     1048              
  Lines      105253   105250       -3     
  Branches      756      756              
==========================================
- Hits        84329    84306      -23     
- Misses      20883    20903      +20     
  Partials       41       41              
Flag Coverage Δ
editoast 74.20% <ø> (-0.07%) ⬇️
front 89.36% <100.00%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SarahBellaha SarahBellaha force-pushed the sba/front/change-grid-margin-default-value branch from f8ac13f to 8f02137 Compare December 10, 2024 13:36
Copy link
Contributor

@RomainValls RomainValls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SarahBellaha SarahBellaha force-pushed the sba/front/change-grid-margin-default-value branch from 8f02137 to dfc1c3b Compare December 10, 2024 14:36
@SarahBellaha SarahBellaha requested a review from a team as a code owner December 10, 2024 14:36
Signed-off-by: SarahBellaha <sarah.bellaha@sncf.fr>
@SarahBellaha SarahBellaha force-pushed the sba/front/change-grid-margin-default-value branch from dfc1c3b to cf356fa Compare December 10, 2024 15:46
Copy link
Contributor

@Maymanaf Maymanaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for e2e tests

@clarani clarani added this pull request to the merge queue Dec 12, 2024
Merged via the queue into dev with commit f458996 Dec 12, 2024
27 checks passed
@clarani clarani deleted the sba/front/change-grid-margin-default-value branch December 12, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: stdcm: reduce grid margins from 35s to 15s
5 participants