schemas: allow extensions to be specified but None #9976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area:railjson
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9976 +/- ##
==========================================
- Coverage 79.88% 79.87% -0.02%
==========================================
Files 1048 1048
Lines 105232 105232
Branches 756 756
==========================================
- Hits 84063 84049 -14
- Misses 21128 21142 +14
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Editoast serialize *all* extensions, even when not present. The pydantic validation should thus allow None Signed-off-by: Younes Khoudli <younes.khoudli@epita.fr>
Khoyo
force-pushed
the
yk/schemas-allow-none-extensions
branch
from
cb2a1f9 to
0237cc7
Compare
leovalais
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Editoast serialize all extensions, even when not present. The pydantic validation should thus allow None