Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix speedspacechart resize behavior #9958

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

Yohh
Copy link
Contributor

@Yohh Yohh commented Dec 5, 2024

close #9909

@Yohh Yohh requested review from clarani and Uriel-Sautron December 5, 2024 10:51
@Yohh Yohh requested a review from a team as a code owner December 5, 2024 10:51
Signed-off-by: Yohh <durandyohan@zaclys.net>
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 5, 2024
@Yohh Yohh force-pushed the yoh/front-fix-speedspacechart-resize-behavior branch from 9ca3359 to 0ff985d Compare December 5, 2024 10:52
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.83%. Comparing base (52ef1ae) to head (0ff985d).
Report is 15 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9958      +/-   ##
==========================================
- Coverage   79.84%   79.83%   -0.01%     
==========================================
  Files        1048     1048              
  Lines      105062   105076      +14     
  Branches      756      756              
==========================================
+ Hits        83887    83891       +4     
- Misses      21134    21144      +10     
  Partials       41       41              
Flag Coverage Δ
editoast 73.32% <ø> (-0.07%) ⬇️
front 89.34% <100.00%> (+0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yohh Yohh changed the title front: fix speedspacechart-resize-behavior front: fix speedspacechart resize behavior Dec 5, 2024
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work

@Yohh Yohh added this pull request to the merge queue Dec 5, 2024
Merged via the queue into dev with commit 255cf0a Dec 5, 2024
27 checks passed
@Yohh Yohh deleted the yoh/front-fix-speedspacechart-resize-behavior branch December 5, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The GEV takes some time to adjust to the correct size
4 participants