-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STDCM: linked path search adjustments #9953
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9953 +/- ##
==========================================
- Coverage 79.82% 79.81% -0.01%
==========================================
Files 1053 1053
Lines 105483 105485 +2
Branches 727 727
==========================================
- Hits 84197 84191 -6
- Misses 21244 21252 +8
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Nit: "LMR" is the internal SNCF-specific name, for the open-source project "STDCM" is still used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (tested)
8c267c4
to
cb06bcb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
Signed-off-by: SarahBellaha <sarah.bellaha@sncf.fr>
cb06bcb
to
30cb5ba
Compare
This PR will close some small issues we have on the linked path search:
Closes STDCM: No results displayed for linked path search
Closes STDCM: The train name is centered when there is one result in the linked path search
Closes STDCM: Unable to perform a new search after changing the date for the linked path