Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STDCM: linked path search adjustments #9953

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

SarahBellaha
Copy link
Contributor

@SarahBellaha SarahBellaha commented Dec 5, 2024

@SarahBellaha SarahBellaha requested a review from a team as a code owner December 5, 2024 08:04
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.81%. Comparing base (c9d8360) to head (30cb5ba).
Report is 3 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9953      +/-   ##
==========================================
- Coverage   79.82%   79.81%   -0.01%     
==========================================
  Files        1053     1053              
  Lines      105483   105485       +2     
  Branches      727      727              
==========================================
- Hits        84197    84191       -6     
- Misses      21244    21252       +8     
  Partials       42       42              
Flag Coverage Δ
editoast 73.72% <ø> (-0.03%) ⬇️
front 89.13% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emersion
Copy link
Member

emersion commented Dec 5, 2024

Nit: "LMR" is the internal SNCF-specific name, for the open-source project "STDCM" is still used.

Copy link
Contributor

@Caracol3 Caracol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (tested)

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Signed-off-by: SarahBellaha <sarah.bellaha@sncf.fr>
@SarahBellaha SarahBellaha force-pushed the sba/front/bug-fix-9925 branch from cb06bcb to 30cb5ba Compare December 17, 2024 13:48
@SarahBellaha SarahBellaha added this pull request to the merge queue Dec 17, 2024
Merged via the queue into dev with commit c6daa01 Dec 17, 2024
28 checks passed
@SarahBellaha SarahBellaha deleted the sba/front/bug-fix-9925 branch December 17, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
5 participants