Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: introduce Duration type #9934

Merged
merged 4 commits into from
Jan 13, 2025
Merged

front: introduce Duration type #9934

merged 4 commits into from
Jan 13, 2025

Conversation

emersion
Copy link
Member

@emersion emersion commented Dec 3, 2024 •
edited
Loading

See #8816

See individual commits.

Follow-up work: drop duration-related helpers from utils/timeManipulation, use Duration everywhere instead of strings/numbers.

@emersion emersion self-assigned this Dec 3, 2024
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 3, 2024
@emersion emersion force-pushed the emr/duration-type branch 2 times, most recently from 4c75fa7 to 707a258 Compare December 23, 2024 16:15
@emersion emersion force-pushed the emr/duration-type branch 2 times, most recently from f7d9a22 to dfd560e Compare January 3, 2025 10:04
@emersion emersion requested review from clarani and theocrsb January 3, 2025 10:17
@emersion emersion marked this pull request as ready for review January 3, 2025 10:17
@emersion emersion requested a review from a team as a code owner January 3, 2025 10:17
@emersion emersion mentioned this pull request Jan 3, 2025
Merged
theocrsb
theocrsb approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested :)

@clarani clarani mentioned this pull request Jan 7, 2025
Closed
@emersion emersion force-pushed the emr/duration-type branch 3 times, most recently from 8d0998f to 3884aa5 Compare January 10, 2025 11:09
clarani
clarani approved these changes Jan 10, 2025
View reviewed changes
front/src/utils/duration.ts Outdated Show resolved Hide resolved
@emersion
front: introduce Duration type
400ac86 
Signed-off-by: Simon Ser <contact@emersion.fr>
References: #8816
@emersion
front: use Duration instead of string in SuggestedOP.arrival
41d78a7 
Signed-off-by: Simon Ser <contact@emersion.fr>
@emersion
front: use Duration instead of string in PathStep.arrival
925f3f5 
Signed-off-by: Simon Ser <contact@emersion.fr>
@emersion
front: drop IsoDurationString
f81bf55 
This is now unused.

Signed-off-by: Simon Ser <contact@emersion.fr>
@emersion emersion added this pull request to the merge queue Jan 13, 2025
Merged via the queue into dev with commit d0befa4 Jan 13, 2025
27 checks passed
@emersion emersion deleted the emr/duration-type branch January 13, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theocrsb theocrsb theocrsb approved these changes

@clarani clarani clarani approved these changes

Assignees

@emersion emersion

Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emersion @clarani @theocrsb