front: move useSimulationResults in SimulationResults #9885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9885 +/- ##
==========================================
- Coverage 79.85% 79.84% -0.01%
==========================================
Files 1048 1048
Lines 105046 105039 -7
Branches 756 756
==========================================
- Hits 83883 83872 -11
- Misses 21122 21126 +4
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
clarani
force-pushed
the
cni/9884-move-usesimulationresults
branch
2 times, most recently
from
f2bb5ca to
176ef03
Compare
clarani
force-pushed
the
cni/9884-move-usesimulationresults
branch
from
176ef03 to
ef76be5
Compare
clarani
force-pushed
the
cni/9884-move-usesimulationresults
branch
from
ef76be5 to
f5fb0da
Compare
Moving this hook in SimulationResults avoids unnecessary renders and bring the code closer to where it is used. Signed-off-by: Clara Ni <clara.ni@outlook.fr>
- Removed the first condition trainSimulation.status === 'success' to allow the user to see the SpaceTimeChart even if the current selected train is invalid. - Removed not needed condition on pathproperties to display the spacetimechart Signed-off-by: Clara Ni <clara.ni@outlook.fr>
clarani
force-pushed
the
cni/9884-move-usesimulationresults
branch
from
f5fb0da to
d6b49dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9884