Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: stdcm: update simulation progress button design #9786

Merged
merged 5 commits into from
Dec 5, 2024
Merged

front: stdcm: update simulation progress button design #9786

merged 5 commits into from
Dec 5, 2024

Conversation

SharglutDev
Copy link
Contributor

@SharglutDev SharglutDev commented Nov 19, 2024 •
edited
Loading

close #9677
fix #9322

To test popup behavior :

  • Animation is not on sketch yet and its duration will be validated with @thibautsailly on November 25th.
    When launching a simulation, the launch button should fade out while the simulation progress popup should fade in from the bottom.
  • The popup should be sticky to the bottom if it doesn't fit below the form and be fixed to the top when scrolling far bottom (if you have already a simulation in the results, you can toggle the op list to increase the height and test the behavior)

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.85%. Comparing base (908d2aa) to head (b2e18dc).
Report is 15 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #9786      +/-   ##
==========================================
+ Coverage   79.84%   79.85%   +0.01%     
==========================================
  Files        1048     1047       -1     
  Lines      105060   105119      +59     
  Branches      756      756              
==========================================
+ Hits        83887    83946      +59     
  Misses      21132    21132              
  Partials       41       41
Flag Coverage Δ
editoast 73.35% <ø> (-0.04%) ⬇️
front 89.35% <100.00%> (+0.02%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SharglutDev SharglutDev force-pushed the pfn/front/stdcm/update-simulation-progress-button-design branch 3 times, most recently from 63db8cf to 7ce3be2 Compare November 21, 2024 12:46
@SharglutDev SharglutDev marked this pull request as ready for review November 21, 2024 12:52
@SharglutDev SharglutDev requested a review from a team as a code owner November 21, 2024 12:52
@SharglutDev
Copy link
Contributor Author

@Maymanaf, tagged you so you can check I don't break e2e tests

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 21, 2024
@SharglutDev
Copy link
Contributor Author

SharglutDev commented Nov 21, 2024 •
edited
Loading

There is still an issue which needs to be investigated (probably related to your comment @emersion). When the form is long, the threshold for the position switch isn't good anymore because scrollY reaches innerHeight - LOADER_OFFSET * 2 sooner

@clarani clarani changed the title Pfn/front/stdcm/update simulation progress button design front: stdcm: update simulation progress button design Nov 22, 2024
@SharglutDev SharglutDev force-pushed the pfn/front/stdcm/update-simulation-progress-button-design branch 2 times, most recently from 2b6b85d to ae13c2f Compare November 29, 2024 13:19
@Maymanaf
Copy link
Contributor

@Maymanaf, tagged you so you can check I don't break e2e tests

Since the E2E tests for LMR run very quickly, I didn't include a check for the simulation progress to avoid flakiness, as the test might fail to detect it.

@SharglutDev SharglutDev requested a review from emersion November 29, 2024 13:38
@emersion
Copy link
Member

emersion commented Dec 2, 2024

Random side note: really not a fan of these manual size computations. Would really prefer if this were just a simple pure CSS position: sticky element.

@emersion emersion removed their request for review December 2, 2024 14:45
@SharglutDev SharglutDev force-pushed the pfn/front/stdcm/update-simulation-progress-button-design branch from ae13c2f to a8bfcca Compare December 3, 2024 10:27
clarani
clarani approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@SharglutDev SharglutDev force-pushed the pfn/front/stdcm/update-simulation-progress-button-design branch from b81faad to e8e4f3f Compare December 4, 2024 10:53
@SharglutDev SharglutDev enabled auto-merge December 4, 2024 10:56
theocrsb
theocrsb approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested

@SharglutDev SharglutDev force-pushed the pfn/front/stdcm/update-simulation-progress-button-design branch from 8af599b to 7a409f7 Compare December 4, 2024 15:36
@SharglutDev SharglutDev requested a review from a team as a code owner December 4, 2024 15:36
@SharglutDev SharglutDev requested a review from clarani December 4, 2024 19:55
@SharglutDev SharglutDev disabled auto-merge December 4, 2024 19:55
Maymanaf
Maymanaf approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@Maymanaf Maymanaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for e2e tests

clarani
clarani approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@SharglutDev
front: fix stdcm e2e test on tolerance picker
a34d9c7 
Currently there is no way to close the tolerance picker modal and it can block the next test action.
Add a click on the map to close it before continuing the tests while waiting for the close button to be implemented.

Signed-off-by: SharglutDev <p.filimon75@gmail.com>
@SharglutDev
front: update stdcm simulation progress button design
8180e72 
Signed-off-by: SharglutDev <p.filimon75@gmail.com>
@SharglutDev
front: fix stdcm status banner width
95b292a 
Signed-off-by: SharglutDev <p.filimon75@gmail.com>
@SharglutDev
front: keep stdcm results displayed while simulation is in progress
bea8090 
Signed-off-by: SharglutDev <p.filimon75@gmail.com>
@SharglutDev
front: fix some consist inputs not being disabled while simulation is…
b2e18dc 
… in progress

Signed-off-by: SharglutDev <p.filimon75@gmail.com>
@SharglutDev SharglutDev force-pushed the pfn/front/stdcm/update-simulation-progress-button-design branch from 7a409f7 to b2e18dc Compare December 5, 2024 14:14
@SharglutDev SharglutDev enabled auto-merge December 5, 2024 14:15
@SharglutDev SharglutDev added this pull request to the merge queue Dec 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 5, 2024
@SharglutDev SharglutDev added this pull request to the merge queue Dec 5, 2024
Merged via the queue into dev with commit 7a0728b Dec 5, 2024
27 checks passed
@SharglutDev SharglutDev deleted the pfn/front/stdcm/update-simulation-progress-button-design branch December 5, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersion emersion emersion left review comments

@theocrsb theocrsb theocrsb approved these changes

@clarani clarani clarani approved these changes

@Maymanaf Maymanaf Maymanaf approved these changes

@SarahBellaha SarahBellaha Awaiting requested review from SarahBellaha

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
6 participants
@SharglutDev @codecov-commenter @Maymanaf @emersion @clarani @theocrsb